-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test user for maps test verifying sample data maps #96109
Conversation
…to TestUserSampleDataMap
⏳ Build in-progress, with failures
Failed CI StepsHistory
To update your PR or re-run it, just comment with: cc @bhavyarm |
Pinging @elastic/kibana-gis (Team:Geo) |
@bhavyarm Are the user docs in alignment with what you're finding in these tests as far as roles or permissions? |
@@ -80,15 +89,25 @@ export default function ({ getPageObjects, getService, updateBaselines }) { | |||
await kibanaServer.uiSettings.update({ | |||
[UI_SETTINGS.TIMEPICKER_QUICK_RANGES]: SAMPLE_DATA_RANGE, | |||
}); | |||
await security.testUser.setRoles( | |||
['global_maps_all', 'geoall_data_writer', 'kibana_sample_admin'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need 'geoall_data_writer' here? It's not clear to me why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we do. If I we don't - we can't add the sample data index patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But the sample data was already loaded before this step as the default superuser.
@LeeDr yes I saw good error messages on the screen without them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review
@elasticmachine merge upstream |
@bhavyarm Disabling the upload card when users can not create index patterns was recently added. The goal is to fail early in the upload process instead of letting someone upload a file but then not have permissions to create an index pattern. Required permissions are documented at https://www.elastic.co/guide/en/kibana/7.x/import-geospatial-data.html#import-geospatial-privileges |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Code review and discussed with Bhavya
Thanks @nreese |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @bhavyarm |
test user for sample maps test & removing geoall_writer_role from add layer
Meta issue - #60815
This PR is doing two things: